.ctm in data simulator annotator compliant with RT-09 specification #8004

popcornell · 2023-12-09T00:20:06Z

Redid this PR from #7999

An attempt to fix #7445 so that the data simulator .ctm are compliant with RT-09 specification (see https://web.archive.org/web/20170119114252/http://www.itl.nist.gov/iad/mig/tests/rt/2009/docs/rt09-meeting-eval-plan-v2.pdf):

<SOURCE><SP><CHANNEL><SP> <BEG-TIME><SP><DURATION><SP><TOKEN><SP>
<CONF><SP><TYPE><SP><SPEAKER><NEWLINE>

I have put for fields unknown e.g. .
This makes it also easy to use the generated sessions with https://github.com/lhotse-speech/lhotse

Signed-off-by: popcornell <[email protected]>

tango4j · 2023-12-11T17:47:59Z

NeMo contributors, please do not merge this PR until I make sure all the CTM in NeMo is following the official CTM format.

Signed-off-by: popcornell <[email protected]>

popcornell · 2023-12-11T21:13:15Z

Seems that also this is not compliant (speaker id instead of channel):

https://github.com/NVIDIA/NeMo/blob/fa8d416793d850f4ce56bea65e1fe28cc0d092c0/scripts/speaker_tasks/create_alignment_manifest.py#L74C79-L74C79

This is instead kinda compliant (but lacks for missing fields):

NeMo/tools/nemo_forced_aligner/utils/make_ctm_files.py

Line 108 in fa8d416

    
           f_ctm.write(f"{utt_obj.utt_id} 1 {start_time:.2f} {end_time - start_time:.2f} {text}\n")

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

Signed-off-by: Taejin Park <[email protected]>

for more information, see https://pre-commit.ci

tango4j · 2023-12-12T04:12:28Z

@erastorgueva-nv Elena, I have found a line that renders CTM and I replaced with the get_ctm_line to remove the duplication when users create CTM files with NeMo. Please check if there is anything wrong happening and this does not cause any errors. (There is no unit tests for the make_ctm_files.py)

@stevehuang52 We are also making slight changes to data simulator. Please review and approve.

nemo/collections/asr/parts/utils/data_simulation_utils.py

tools/nemo_forced_aligner/utils/make_ctm_files.py

tests/collections/asr/utils/test_data_simul_utils.py

Signed-off-by: Taejin Park <[email protected]>

erastorgueva-nv · 2023-12-13T22:20:39Z

nemo/collections/asr/parts/utils/manifest_utils.py

+    if type(beg_time) != float:
+        beg_time = round(float(beg_time), output_precision)
+    if type(duration) != float:
+        duration = round(float(duration), output_precision)


Currently, beg_time and duration do not get rounded if they are floats already. Please remove the if-statements, I don't think they are necessary.

Updated to always round the number. Also checking whether beg_time is either float or string containing floating point number.

Signed-off-by: Taejin Park <[email protected]>

tango4j

Approving this, since this PR went through several rounds of reviews and feedbacks.

titu1994 · 2023-12-29T19:09:33Z

jenkins

titu1994 · 2023-12-29T19:12:28Z

@tango4j / reviewers, merge when ready.

Also reminder, NeMo devs need to explicitly write "jenkins" in order to execute the CI

tango4j · 2023-12-29T23:20:05Z

@tango4j / reviewers, merge when ready.

Also reminder, NeMo devs need to explicitly write "jenkins" in order to execute the CI

Oh, when did it change the protocol?
Thanks for the heads up. From now on, I will do "jenkins".

stevehuang52 · 2024-01-02T14:30:07Z

jenkins

tango4j · 2024-01-02T22:27:35Z

jenkins

Signed-off-by: Taejin Park <[email protected]>

tango4j · 2024-01-05T00:51:55Z

jenkins

nemo/collections/asr/parts/utils/manifest_utils.py

Signed-off-by: Taejin Park <[email protected]>

tango4j · 2024-01-05T20:07:58Z

jenkins

tango4j · 2024-01-06T08:38:25Z

jenkins

tango4j

Approving changes

…VIDIA#8004) * .ctm fix for data simulation Signed-off-by: popcornell <[email protected]> * .ctm fix, channel should be 1 not 0 Signed-off-by: popcornell <[email protected]> * .ctm fix, only two na, type and confidence Signed-off-by: popcornell <[email protected]> * Revised all the parts in NeMo touching CTM files Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated tutorial, nemo-docs and tests for CTM formats Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed the docstrings in create_alignment_manifest.py Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Some missing refactored variables for type_of_token Signed-off-by: Taejin Park <[email protected]> * Another un-fixed part in data_simulation_utils.py Signed-off-by: Taejin Park <[email protected]> * Reflected comments from PR Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reflected another precision related comments from PR Signed-off-by: Taejin Park <[email protected]> * Updated tests to use decimal rounding of 2 Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Changed beg_time to start_time and fixed unit tests Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed typos and errors in manifest_utils.py Signed-off-by: Taejin Park <[email protected]> * Resolved another merge conflict Signed-off-by: Taejin Park <[email protected]> * Fixed the test errors Signed-off-by: Taejin Park <[email protected]> * Fixed the missed commented lines Signed-off-by: Taejin Park <[email protected]> --------- Signed-off-by: popcornell <[email protected]> Signed-off-by: Taejin Park <[email protected]> Co-authored-by: Taejin Park <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <[email protected]>

…VIDIA#8004) * .ctm fix for data simulation Signed-off-by: popcornell <[email protected]> * .ctm fix, channel should be 1 not 0 Signed-off-by: popcornell <[email protected]> * .ctm fix, only two na, type and confidence Signed-off-by: popcornell <[email protected]> * Revised all the parts in NeMo touching CTM files Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated tutorial, nemo-docs and tests for CTM formats Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed the docstrings in create_alignment_manifest.py Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Some missing refactored variables for type_of_token Signed-off-by: Taejin Park <[email protected]> * Another un-fixed part in data_simulation_utils.py Signed-off-by: Taejin Park <[email protected]> * Reflected comments from PR Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reflected another precision related comments from PR Signed-off-by: Taejin Park <[email protected]> * Updated tests to use decimal rounding of 2 Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Changed beg_time to start_time and fixed unit tests Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed typos and errors in manifest_utils.py Signed-off-by: Taejin Park <[email protected]> * Resolved another merge conflict Signed-off-by: Taejin Park <[email protected]> * Fixed the test errors Signed-off-by: Taejin Park <[email protected]> * Fixed the missed commented lines Signed-off-by: Taejin Park <[email protected]> --------- Signed-off-by: popcornell <[email protected]> Signed-off-by: Taejin Park <[email protected]> Co-authored-by: Taejin Park <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <[email protected]> Signed-off-by: Sasha Meister <[email protected]>

…VIDIA#8004) * .ctm fix for data simulation Signed-off-by: popcornell <[email protected]> * .ctm fix, channel should be 1 not 0 Signed-off-by: popcornell <[email protected]> * .ctm fix, only two na, type and confidence Signed-off-by: popcornell <[email protected]> * Revised all the parts in NeMo touching CTM files Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Updated tutorial, nemo-docs and tests for CTM formats Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed the docstrings in create_alignment_manifest.py Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Some missing refactored variables for type_of_token Signed-off-by: Taejin Park <[email protected]> * Another un-fixed part in data_simulation_utils.py Signed-off-by: Taejin Park <[email protected]> * Reflected comments from PR Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reflected another precision related comments from PR Signed-off-by: Taejin Park <[email protected]> * Updated tests to use decimal rounding of 2 Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Changed beg_time to start_time and fixed unit tests Signed-off-by: Taejin Park <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed typos and errors in manifest_utils.py Signed-off-by: Taejin Park <[email protected]> * Resolved another merge conflict Signed-off-by: Taejin Park <[email protected]> * Fixed the test errors Signed-off-by: Taejin Park <[email protected]> * Fixed the missed commented lines Signed-off-by: Taejin Park <[email protected]> --------- Signed-off-by: popcornell <[email protected]> Signed-off-by: Taejin Park <[email protected]> Co-authored-by: Taejin Park <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: He Huang (Steve) <[email protected]>

.ctm fix for data simulation

45baf76

Signed-off-by: popcornell <[email protected]>

github-actions bot added the ASR label Dec 9, 2023

Merge branch 'main' into ctm

6528af1

tango4j and others added 4 commits December 11, 2023 11:25

Merge branch 'main' into ctm

6e2aa4e

.ctm fix, channel should be 1 not 0

c9a5b53

Signed-off-by: popcornell <[email protected]>

Merge remote-tracking branch 'popcornell/ctm' into ctm

6a278db

.ctm fix, only two na, type and confidence

ca27864

Signed-off-by: popcornell <[email protected]>

tango4j added 2 commits December 11, 2023 16:33

Revised all the parts in NeMo touching CTM files

8b62af8

Signed-off-by: Taejin Park <[email protected]>

Making all files writing CTM uses the same function

a4dd387

Signed-off-by: Taejin Park <[email protected]>

github-actions bot added the Speaker Tasks label Dec 12, 2023

pre-commit-ci bot and others added 8 commits December 12, 2023 00:50

[pre-commit.ci] auto fixes from pre-commit.com hooks

dcfb24a

for more information, see https://pre-commit.ci

Updated tutorial, nemo-docs and tests for CTM formats

ccb6005

Signed-off-by: Taejin Park <[email protected]>

Fixed type_of_token arg name in create_alignment_manifest script

f0e7ea7

Signed-off-by: Taejin Park <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

e76e85a

for more information, see https://pre-commit.ci

Fixed the docstrings in create_alignment_manifest.py

d447492

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'ctm' of https://github.com/popcornell/NeMo into ctm

2e86423

[pre-commit.ci] auto fixes from pre-commit.com hooks

9714854

for more information, see https://pre-commit.ci

Merge branch 'main' into ctm

343c9a7

tango4j requested review from erastorgueva-nv and stevehuang52 December 12, 2023 04:06

github-advanced-security bot found potential problems Dec 12, 2023

View reviewed changes

tango4j and others added 5 commits December 11, 2023 20:57

Some missing refactored variables for type_of_token

0de3390

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'ctm' of https://github.com/popcornell/NeMo into ctm

223dc9c

Another un-fixed part in data_simulation_utils.py

6e6344e

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'main' into ctm

a0397ea

Merge branch 'main' into ctm

7659d0c

erastorgueva-nv requested changes Dec 13, 2023

View reviewed changes

tango4j added 2 commits December 18, 2023 15:40

Fixed typos and errors in manifest_utils.py

1166231

Signed-off-by: Taejin Park <[email protected]>

Resolved the merge conflicts

3c82369

Signed-off-by: Taejin Park <[email protected]>

tango4j dismissed erastorgueva-nv’s stale review via 3c82369 December 18, 2023 23:42

tango4j added 3 commits December 18, 2023 15:43

Resolved another merge conflict

4c2421f

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'main' into ctm

9bd0e25

Merge branch 'main' into ctm

9d73f23

tango4j previously approved these changes Dec 29, 2023

View reviewed changes

Merge branch 'main' into ctm

378a14d

Merge branch 'main' into ctm

e6f16c7

Fixed the test errors

a56d047

Signed-off-by: Taejin Park <[email protected]>

tango4j dismissed their stale review via a56d047 January 5, 2024 00:51

Merge branch 'main' into ctm

3889596

github-advanced-security bot found potential problems Jan 5, 2024

View reviewed changes

nemo/collections/asr/parts/utils/manifest_utils.py Fixed Show fixed Hide fixed

tango4j added 3 commits January 5, 2024 12:07

Fixed the missed commented lines

851f716

Signed-off-by: Taejin Park <[email protected]>

Merge branch 'ctm' of https://github.com/popcornell/NeMo into ctm

68cf52f

Merge branch 'main' into ctm

56a2123

Merge branch 'main' into ctm

329bc0d

tango4j approved these changes Jan 8, 2024

View reviewed changes

tango4j merged commit ef6ed61 into NVIDIA:main Jan 8, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.ctm in data simulator annotator compliant with RT-09 specification #8004

.ctm in data simulator annotator compliant with RT-09 specification #8004

popcornell commented Dec 9, 2023

tango4j commented Dec 11, 2023

popcornell commented Dec 11, 2023

tango4j commented Dec 12, 2023

erastorgueva-nv Dec 13, 2023

tango4j Dec 13, 2023

tango4j left a comment

titu1994 commented Dec 29, 2023

titu1994 commented Dec 29, 2023

tango4j commented Dec 29, 2023

stevehuang52 commented Jan 2, 2024

tango4j commented Jan 2, 2024

tango4j commented Jan 5, 2024

tango4j commented Jan 5, 2024

tango4j commented Jan 6, 2024

tango4j left a comment

.ctm in data simulator annotator compliant with RT-09 specification #8004

.ctm in data simulator annotator compliant with RT-09 specification #8004

Conversation

popcornell commented Dec 9, 2023

tango4j commented Dec 11, 2023

popcornell commented Dec 11, 2023

tango4j commented Dec 12, 2023

erastorgueva-nv Dec 13, 2023

Choose a reason for hiding this comment

tango4j Dec 13, 2023

Choose a reason for hiding this comment

tango4j left a comment

Choose a reason for hiding this comment

titu1994 commented Dec 29, 2023

titu1994 commented Dec 29, 2023

tango4j commented Dec 29, 2023

stevehuang52 commented Jan 2, 2024

tango4j commented Jan 2, 2024

tango4j commented Jan 5, 2024

tango4j commented Jan 5, 2024

tango4j commented Jan 6, 2024

tango4j left a comment

Choose a reason for hiding this comment