[TTS] Scale sampler steps by number of devices #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlangman
requested review from
XuesongYang,
KunalDhawan,
nithinraok and
anteju
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: Ryan <[email protected]>
anteju
approved these changes
Dec 13, 2023
|
jenkins |
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Ryan <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Ryan <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The weighted random sampler is configured to produce a fixed number of training samples during each epoch. This means if you use multiple GPUs, then the number of steps in each epoch is scaled down by the number of GPUs. This change multiplies the number of samples by the world size to keep the step count independent of number of GPUs used.
Collection: [TTS]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: