Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Dutch P&C FC model info #7892

Merged
merged 2 commits into from
Nov 23, 2023
Merged

add Dutch P&C FC model info #7892

merged 2 commits into from
Nov 23, 2023

Conversation

zhehuaichen
Copy link
Collaborator

What does this PR do ?

Update scores table for Fast Conformer Dutch models

Collection: [ASR]

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@zhehuaichen
add Dutch P&C FC model info
fed72a5 
Signed-off-by: zhehuaichen <[email protected]>
@github-actions github-actions bot added the ASR label Nov 15, 2023
@nithinraok
Copy link
Collaborator

jenkins

nithinraok
nithinraok requested changes Nov 17, 2023
View reviewed changes
docs/source/asr/scores.rst Outdated Show resolved Hide resolved
@zhehuaichen
update order of the results
85c3b6b 
Signed-off-by: zhehuaichen <[email protected]>
nithinraok
nithinraok approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.

@nithinraok
Copy link
Collaborator

jenkins

@zhehuaichen zhehuaichen merged commit 521cfb4 into main Nov 23, 2023
15 checks passed
@zhehuaichen zhehuaichen deleted the dutch branch November 23, 2023 01:35
erhoo82 pushed a commit to erhoo82/NeMo that referenced this pull request Dec 2, 2023
@cuichenx @erhoo82
support packed dataset
2b43e70 
Signed-off-by: Chen Cui <[email protected]>

support packed dataset

Signed-off-by: Chen Cui <[email protected]>

[Codec] Finite scalar quantizer (NVIDIA#7886)

* Finite scalar quantizer

Signed-off-by: Ante Jukić <[email protected]>

* Updated test

Signed-off-by: Ante Jukić <[email protected]>

---------

Signed-off-by: Ante Jukić <[email protected]>

upgrade to latest mcore and TE (NVIDIA#7908)

* reimport module

Signed-off-by: dimapihtar <[email protected]>

* update mcore and TE commits

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>

Tar codec (NVIDIA#7867)

added missing torch import (NVIDIA#7913)

Signed-off-by: David Mosallanezhad <[email protected]>

add cpu init check (NVIDIA#7889)

Signed-off-by: Chen Cui <[email protected]>

Fix pinned triton version (NVIDIA#7925)

* Fix pinned triton version

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Remove comment

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change README

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Remove flash-attn in Dockerfile

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Revert

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

---------

Signed-off-by: Cheng-Ping Hsieh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

fix tp_overlap config var name (NVIDIA#7928)

Signed-off-by: Xiaowei Ren <[email protected]>

add Dutch P&C FC model info (NVIDIA#7892)

* add Dutch P&C FC model info

Signed-off-by: zhehuaichen <[email protected]>

* update order of the results

Signed-off-by: zhehuaichen <[email protected]>

---------

Signed-off-by: zhehuaichen <[email protected]>

fix issues with convert_nemo_llama_to_hf.py (NVIDIA#7922)

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

fix collate_fn bug for TP > 1

Signed-off-by: Chen Cui <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

make packed dataset work

Signed-off-by: Chen Cui <[email protected]>

fix nan bug

Signed-off-by: Chen Cui <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

support answer only loss

Signed-off-by: Chen Cui <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

account for padding in cu_seqlens during dataloading for attn kernel

Signed-off-by: Chen Cui <[email protected]>

fix path for answer_only_loss = false

Signed-off-by: Chen Cui <[email protected]>

Modify GPTSFTPackedDataset to respond to pad_to_max_length setting

Signed-off-by: Valerie Sarge <[email protected]>
erhoo82 pushed a commit to erhoo82/NeMo that referenced this pull request Dec 2, 2023
@cuichenx @erhoo82
support packed dataset
44cb7fd 
Signed-off-by: Chen Cui <[email protected]>

support packed dataset

Signed-off-by: Chen Cui <[email protected]>

[Codec] Finite scalar quantizer (NVIDIA#7886)

* Finite scalar quantizer

Signed-off-by: Ante Jukić <[email protected]>

* Updated test

Signed-off-by: Ante Jukić <[email protected]>

---------

Signed-off-by: Ante Jukić <[email protected]>

upgrade to latest mcore and TE (NVIDIA#7908)

* reimport module

Signed-off-by: dimapihtar <[email protected]>

* update mcore and TE commits

Signed-off-by: dimapihtar <[email protected]>

---------

Signed-off-by: dimapihtar <[email protected]>

Tar codec (NVIDIA#7867)

added missing torch import (NVIDIA#7913)

Signed-off-by: David Mosallanezhad <[email protected]>

add cpu init check (NVIDIA#7889)

Signed-off-by: Chen Cui <[email protected]>

Fix pinned triton version (NVIDIA#7925)

* Fix pinned triton version

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Remove comment

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change README

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Remove flash-attn in Dockerfile

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Revert

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

---------

Signed-off-by: Cheng-Ping Hsieh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

fix tp_overlap config var name (NVIDIA#7928)

Signed-off-by: Xiaowei Ren <[email protected]>

add Dutch P&C FC model info (NVIDIA#7892)

* add Dutch P&C FC model info

Signed-off-by: zhehuaichen <[email protected]>

* update order of the results

Signed-off-by: zhehuaichen <[email protected]>

---------

Signed-off-by: zhehuaichen <[email protected]>

fix issues with convert_nemo_llama_to_hf.py (NVIDIA#7922)

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

fix collate_fn bug for TP > 1

Signed-off-by: Chen Cui <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

make packed dataset work

Signed-off-by: Chen Cui <[email protected]>

fix nan bug

Signed-off-by: Chen Cui <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

support answer only loss

Signed-off-by: Chen Cui <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

account for padding in cu_seqlens during dataloading for attn kernel

Signed-off-by: Chen Cui <[email protected]>

fix path for answer_only_loss = false

Signed-off-by: Chen Cui <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
@zhehuaichen @pzelasko
add Dutch P&C FC model info (NVIDIA#7892)
1b466c6 
* add Dutch P&C FC model info

Signed-off-by: zhehuaichen <[email protected]>

* update order of the results

Signed-off-by: zhehuaichen <[email protected]>

---------

Signed-off-by: zhehuaichen <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@zhehuaichen
add Dutch P&C FC model info (NVIDIA#7892)
58ad0d5 
* add Dutch P&C FC model info

Signed-off-by: zhehuaichen <[email protected]>

* update order of the results

Signed-off-by: zhehuaichen <[email protected]>

---------

Signed-off-by: zhehuaichen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithinraok nithinraok nithinraok approved these changes

@titu1994 titu1994 Awaiting requested review from titu1994

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhehuaichen @nithinraok