[TTS] Add period discriminator and feature matching loss to codec recipe #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
anteju
previously approved these changes
Dec 13, 2023
| def __init__(self, period): | ||
| super().__init__() | ||
| self.period = period | ||
| self.activation = nn.LeakyReLU(0.1) |
There was a problem hiding this comment.
Add slope as an input parameter?
| def output_types(self): | ||
| return { | ||
| "score": NeuralType(('B', 'D', 'T'), VoidType()), | ||
| "fmap": [NeuralType(("B", "C", "H", "W"), VoidType())], |
There was a problem hiding this comment.
Nit: "B" -> 'B' for consistency
Other dimensions similarly
Also, are H and W actually T and D or C?
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Signed-off-by: Ryan <[email protected]>
Signed-off-by: Ryan <[email protected]>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
…ipe (#7884) * [TTS] Add period discriminator and feature matching loss to codec recipe Signed-off-by: Ryan <[email protected]> * [TTS] Update docs for period discriminator Signed-off-by: Ryan <[email protected]> --------- Signed-off-by: Ryan <[email protected]> Signed-off-by: stevehuang52 <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
…ipe (NVIDIA#7884) * [TTS] Add period discriminator and feature matching loss to codec recipe Signed-off-by: Ryan <[email protected]> * [TTS] Update docs for period discriminator Signed-off-by: Ryan <[email protected]> --------- Signed-off-by: Ryan <[email protected]> Signed-off-by: Sasha Meister <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
…ipe (#7884) * [TTS] Add period discriminator and feature matching loss to codec recipe Signed-off-by: Ryan <[email protected]> * [TTS] Update docs for period discriminator Signed-off-by: Ryan <[email protected]> --------- Signed-off-by: Ryan <[email protected]> Signed-off-by: Pablo Garay <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…ipe (NVIDIA#7884) * [TTS] Add period discriminator and feature matching loss to codec recipe Signed-off-by: Ryan <[email protected]> * [TTS] Update docs for period discriminator Signed-off-by: Ryan <[email protected]> --------- Signed-off-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add the feature matching loss and period discriminator used in most traditional vocoders. These will be used in my next PR which adds a configuration for creating a codec from mel spectrogram.
Collection: [TTS]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: