Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back import guard #7882

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Add back import guard #7882

merged 3 commits into from
Nov 15, 2023

Conversation

cuichenx
Copy link
Collaborator

What does this PR do ?

Add back the import guard that was deleted in a previous PR

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: Chen Cui <[email protected]>
gshennvm
gshennvm previously approved these changes Nov 13, 2023
@ericharper
Copy link
Collaborator

jenkins

Signed-off-by: Chen Cui <[email protected]>
@github-actions github-actions bot added the core Changes to NeMo Core label Nov 15, 2023
@cuichenx
Copy link
Collaborator Author

jenkins

@titu1994 titu1994 merged commit 8cd5f1c into main Nov 15, 2023
15 checks passed
@titu1994 titu1994 deleted the chcui/add_mcore_mixin_import_guard branch November 15, 2023 03:17
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* add back import guard

Signed-off-by: Chen Cui <[email protected]>

* skip failing unit test

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* add back import guard

Signed-off-by: Chen Cui <[email protected]>

* skip failing unit test

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core NLP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants