-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASR] GSS-based mask estimator #7849
Conversation
3f3d6e6
to
0544d58
Compare
jenkins |
0544d58
to
848f1fd
Compare
jenkins |
848f1fd
to
83e3434
Compare
jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the example code in the PR description without a problem,
I ran tests/collections/asr/test_audio_modules.py
without a problem for both cpu and gpu.
I think the test runs can be faster if we use pytest.mark.parameterize() for TestMaskEstimator
. This is the only major comment I would like to make.
Signed-off-by: Ante Jukić <[email protected]>
b1f803e
to
a00a409
Compare
Signed-off-by: Ante Jukić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the comments are well addressed. The new test is passing without a problem.
Approving.
This error keeps appearing regardless of commits so commented when I was running the tests. |
jenkins |
* Added GSS-based mask estimator for multispeaker scenarios Signed-off-by: Ante Jukić <[email protected]> * Addressed PR comments Signed-off-by: Ante Jukić <[email protected]> --------- Signed-off-by: Ante Jukić <[email protected]> Co-authored-by: Taejin Park <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
* Added GSS-based mask estimator for multispeaker scenarios Signed-off-by: Ante Jukić <[email protected]> * Addressed PR comments Signed-off-by: Ante Jukić <[email protected]> --------- Signed-off-by: Ante Jukić <[email protected]> Co-authored-by: Taejin Park <[email protected]>
What does this PR do ?
Adding GSS mask estimator for use in multispeaker scenarios.
Collection: ASR
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information