Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set context for text memmap to fork #7784

Merged
merged 3 commits into from
Oct 24, 2023
Merged

set context for text memmap to fork #7784

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f48fe8e
set context for text memmap to fork
arendu Oct 23, 2023
2697a96
typo
arendu Oct 23, 2023
211a46a
Merge branch 'main' into adithyare/memmap_pool_ctx
arendu Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nemo/collections/nlp/data/language_modeling/text_memmap_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,8 @@ def build_index_files(
logging.info(f"Processing {len(dataset_paths)} data files using {workers} workers")
# load all files into memmap
start_time = time.time()
with mp.Pool(workers) as p:
ctx = mp.get_context("fork")
with ctx.Pool(workers) as p:
build_status = p.map(
partial(_build_memmap_index_files, newline_int, build_index_fn, index_mapping_dir=index_mapping_dir,),
dataset_paths,
Expand Down
Loading