fix hybrid eval #7759
Merged
fix hybrid eval #7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
titu1994
reviewed
Oct 19, 2023
| @@ -140,7 +140,7 @@ def beam_search_eval( | |||
| level = logging.getEffectiveLevel() | |||
| logging.setLevel(logging.CRITICAL) | |||
| # Reset config | |||
| model.change_decoding_strategy(None) | |||
| model.change_decoding_strategy(decoding_cfg=None, decoder_type="ctc") | |||
There was a problem hiding this comment.
This is only for hybrid models, others don't support this
Signed-off-by: Nikolay Karpov <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
* fix Signed-off-by: Nikolay Karpov <[email protected]> * rename Signed-off-by: Nikolay Karpov <[email protected]> * docs Signed-off-by: Nikolay Karpov <[email protected]> * warning Signed-off-by: Nikolay Karpov <[email protected]> * if Signed-off-by: Nikolay Karpov <[email protected]> --------- Signed-off-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]>
titu1994
pushed a commit
that referenced
this pull request
Oct 19, 2023
* fix * rename * docs * warning * if --------- Signed-off-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]>
burchim
pushed a commit
to burchim/NeMo
that referenced
this pull request
Oct 28, 2023
* fix * rename * docs * warning * if --------- Signed-off-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]> Signed-off-by: maxime burchi <[email protected]>
pzelasko
pushed a commit
to pzelasko/NeMo
that referenced
this pull request
Jan 3, 2024
* fix * rename * docs * warning * if --------- Signed-off-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* fix * rename * docs * warning * if --------- Signed-off-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]> Co-authored-by: Nikolay Karpov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
fix hybrid eval
PR Type:
Who can review?
@titu1994
Additional Information