Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hybrid eval #7757

Merged
merged 8 commits into from
Oct 19, 2023
Merged

fix hybrid eval #7757

merged 8 commits into from
Oct 19, 2023

Conversation

karpnv
Copy link
Collaborator

@karpnv karpnv commented Oct 19, 2023

What does this PR do ?

PR Type:

  • New Feature
  • [ V] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

@titu1994

Additional Information

Signed-off-by: Nikolay Karpov <[email protected]>
@karpnv karpnv requested a review from titu1994 October 19, 2023 13:45
@karpnv karpnv changed the title fix hybri fix hybrid eval Oct 19, 2023
Nikolay Karpov added 3 commits October 19, 2023 07:21
Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
if
Signed-off-by: Nikolay Karpov <[email protected]>
titu1994
titu1994 previously approved these changes Oct 19, 2023
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@karpnv karpnv requested a review from titu1994 October 19, 2023 17:09
@titu1994 titu1994 merged commit e57aff0 into main Oct 19, 2023
13 of 14 checks passed
@titu1994 titu1994 deleted the karpnv/issue7710 branch October 19, 2023 17:10
burchim pushed a commit to burchim/NeMo that referenced this pull request Oct 28, 2023
* fix

Signed-off-by: Nikolay Karpov <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename

Signed-off-by: Nikolay Karpov <[email protected]>

* docs

Signed-off-by: Nikolay Karpov <[email protected]>

* warning

Signed-off-by: Nikolay Karpov <[email protected]>

* if

Signed-off-by: Nikolay Karpov <[email protected]>

---------

Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Karpov <[email protected]>
Signed-off-by: maxime burchi <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* fix

Signed-off-by: Nikolay Karpov <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename

Signed-off-by: Nikolay Karpov <[email protected]>

* docs

Signed-off-by: Nikolay Karpov <[email protected]>

* warning

Signed-off-by: Nikolay Karpov <[email protected]>

* if

Signed-off-by: Nikolay Karpov <[email protected]>

---------

Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Karpov <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fix

Signed-off-by: Nikolay Karpov <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* rename

Signed-off-by: Nikolay Karpov <[email protected]>

* docs

Signed-off-by: Nikolay Karpov <[email protected]>

* warning

Signed-off-by: Nikolay Karpov <[email protected]>

* if

Signed-off-by: Nikolay Karpov <[email protected]>

---------

Signed-off-by: Nikolay Karpov <[email protected]>
Signed-off-by: Nikolay Karpov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nikolay Karpov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants