Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installation of ctc-decoders #7746

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Updated installation of ctc-decoders #7746

merged 3 commits into from
Oct 19, 2023

Conversation

vsl9
Copy link
Collaborator

@vsl9 vsl9 commented Oct 18, 2023

What does this PR do ?

Fixed issue with installation of ctc-decoders and Offline-ASR notebook

Collection: tutorials/asr

Changelog

  • Fixed issue with installation of ctc-decoders and Offline-ASR notebook

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@vsl9 vsl9 requested a review from karpnv October 18, 2023 04:23
@github-actions github-actions bot added the ASR label Oct 18, 2023

# install Boost package for KenLM
wget https://boostorg.jfrog.io/artifactory/main/release/1.80.0/source/boost_1_80_0.tar.bz2 --no-check-certificate && tar --bzip2 -xf $NEMO_PATH/boost_1_80_0.tar.bz2 && cd boost_1_80_0 && ./bootstrap.sh && b2install --layout=tagged link=static,shared threading=multi,single install -j4 || echo FAILURE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add && cd .. to get out from boost_1_80_0 folder

@@ -43,14 +46,9 @@ cd ..
mv OpenSeq2Seq/decoders .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mv OpenSeq2Seq/decoders $NEMO_PATH/

@@ -43,14 +46,9 @@ cd ..
mv OpenSeq2Seq/decoders .
rm -rf OpenSeq2Seq
cd decoders
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd $NEMO_PATH/decoders

Copy link
Collaborator

@karpnv karpnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add $NEMO_PATH to be consistent

@vsl9 vsl9 requested a review from karpnv October 18, 2023 15:11
Copy link
Collaborator

@karpnv karpnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@titu1994 titu1994 merged commit e0086b9 into r1.21.0 Oct 19, 2023
13 checks passed
@titu1994 titu1994 deleted the nb_online_asr_fix branch October 19, 2023 07:15
github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
* - Fixed issue with installation of ctc-decoders and Offline-ASR notebook

Signed-off-by: Vitaly Lavrukhin <[email protected]>

* Updated paths in install_beamsearch_decoders.sh

Signed-off-by: Vitaly Lavrukhin <[email protected]>

---------

Signed-off-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
titu1994 pushed a commit that referenced this pull request Oct 19, 2023
* - Fixed issue with installation of ctc-decoders and Offline-ASR notebook



* Updated paths in install_beamsearch_decoders.sh



---------

Signed-off-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
burchim pushed a commit to burchim/NeMo that referenced this pull request Oct 28, 2023
* - Fixed issue with installation of ctc-decoders and Offline-ASR notebook

* Updated paths in install_beamsearch_decoders.sh

---------

Signed-off-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: maxime burchi <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* - Fixed issue with installation of ctc-decoders and Offline-ASR notebook

* Updated paths in install_beamsearch_decoders.sh

---------

Signed-off-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* - Fixed issue with installation of ctc-decoders and Offline-ASR notebook



* Updated paths in install_beamsearch_decoders.sh



---------

Signed-off-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Vitaly Lavrukhin <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants