Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributed checkpoint average script #7721

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Conversation

yidong72
Copy link
Collaborator

What does this PR do ?

a script to average distributed checkpoint files.

Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments overall looks great

Signed-off-by: Yi Dong <[email protected]>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks !

Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the high level - I don't know the details of the distributed checkpointing, so can't really check the logic thoroughly

@yidong72 yidong72 merged commit 407e46e into main Oct 16, 2023
15 checks passed
@yidong72 yidong72 deleted the dist-checkpoint-average branch October 16, 2023 20:28
burchim pushed a commit to burchim/NeMo that referenced this pull request Oct 28, 2023
* dist checkpoint average script

Signed-off-by: Yi Dong <[email protected]>

* change name

Signed-off-by: Yi Dong <[email protected]>

* change log message

Signed-off-by: Yi Dong <[email protected]>

* address comments

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: maxime burchi <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* dist checkpoint average script

Signed-off-by: Yi Dong <[email protected]>

* change name

Signed-off-by: Yi Dong <[email protected]>

* change log message

Signed-off-by: Yi Dong <[email protected]>

* address comments

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* dist checkpoint average script

Signed-off-by: Yi Dong <[email protected]>

* change name

Signed-off-by: Yi Dong <[email protected]>

* change log message

Signed-off-by: Yi Dong <[email protected]>

* address comments

Signed-off-by: Yi Dong <[email protected]>

---------

Signed-off-by: Yi Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants