Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Falcon Variants (7B/40B/180B) in Mcore NeMo #7666
Support Falcon Variants (7B/40B/180B) in Mcore NeMo #7666
Changes from 49 commits
fe90ac2
ffaf228
562e6f0
8297b5c
2fc07a4
9bafd73
3bf4b54
36fe312
044026d
908004e
c69d577
0610e19
a8684d0
0995272
f2ad089
47d2f23
ed8869a
59e0f2e
03d06bc
71b25b8
9bb2e32
d105603
65fb726
eaa42ff
c4ad769
b9264d4
1c1c7dd
3dcbd38
11fd6cf
508ba85
a9df5a4
d712925
7a46e86
d4a5fec
f186033
fbc7c19
0170f31
1c846b8
42ff405
0fea447
39b78a9
c85f3ac
b0c1bb7
ce1bf4a
8db8992
2bc8286
6351ae9
a6c1fae
1156b6a
5034dfc
c97d38c
4383bd1
b499c88
94f4ba2
8928050
b523440
54ae837
8ebf142
1c1bc51
f3931f7
f84fee6
b545a8b
ea39e68
aea1e81
812ce43
b0966c1
0c9a2e3
8e8ba66
b1e6398
2759755
f737a74
5ad525c
9c4960f
fb04806
e54fdad
7cd8cfb
e51cfa1
beada8c
5d76cf3
fafa39f
27b7694
e7476e8
9028555
0531cff
eb5bf94
5f866da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have many
megatron_*_inference.yaml
configs with minor differences. We could setup some common denominator for them so that it becomes more transparent and manageable (especially that more and more configs are expected to be added in future).That's a general mark cc @ericharper