Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Add dataset to path of logged artifacts #7651

Merged
merged 3 commits into from
Oct 6, 2023
Merged

[TTS] Add dataset to path of logged artifacts #7651

merged 3 commits into from
Oct 6, 2023

Conversation

rlangman
Copy link
Collaborator

@rlangman rlangman commented Oct 6, 2023

What does this PR do ?

Merging #7462 to r1.21.0

Modify callbacks to save artifacts into dataset specific folders, instead of saving artifacts from all datasets into 1 folder. This helps organization when training on many datasets, and also handles the case when multiple datasets have files with the same name.

Collection: [TTS]

Changelog

  • Pass dataset names through TTS data loaders
  • Save artifacts under epoch_{x}/{dataset_name}/
  • Add initial logging for FastPitch and HiFi-GAN recipes

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@rlangman rlangman merged commit 4a7b2a5 into r1.21.0 Oct 6, 2023
13 checks passed
@rlangman rlangman deleted the tts_log branch October 6, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants