Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group-residual vector quantizer #7643

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Group-residual vector quantizer #7643

merged 1 commit into from
Oct 18, 2023

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Oct 5, 2023

What does this PR do ?

This PR adds group-residual vector quantizer as in http://arxiv.org/abs/2305.02765

Collection: TTS

Changelog

  • Added group-RVQ
  • Added unit tests for RVQ

Usage

To use, add the following in the config file

  vector_quantizer:
    _target_: nemo.collections.tts.modules.encodec_modules.GroupResidualVectorQuantizer
    num_codebooks: 4 # total number of codebooks
    num_groups: 2 # number of groups
    codebook_dim: 128 # dimension of the audio encoder output

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@rlangman rlangman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anteju anteju merged commit ed64c7d into NVIDIA:main Oct 18, 2023
10 of 11 checks passed
burchim pushed a commit to burchim/NeMo that referenced this pull request Oct 28, 2023
Signed-off-by: Ante Jukić <[email protected]>
Signed-off-by: maxime burchi <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
Signed-off-by: Ante Jukić <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants