-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors caused by different dimensionality in get_dist function #7490
Conversation
Signed-off-by: eharper <[email protected]>
Signed-off-by: Abhishree <[email protected]> Co-authored-by: Eric Harper <[email protected]>
…#7454) Signed-off-by: Abhishree <[email protected]>
* new frame_confidence and alignments lists are now always created after the while loop Signed-off-by: Aleksandr Laptev <[email protected]> * tests added Signed-off-by: Aleksandr Laptev <[email protected]> --------- Signed-off-by: Aleksandr Laptev <[email protected]> (cherry picked from commit 6012ca2)
Signed-off-by: Nithin Rao Koluguri <nithinraok> Co-authored-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Hongbin Liu <[email protected]> Co-authored-by: Hongbin Liu <[email protected]>
this is a bugfix for r1.21.0. Please change the base. |
Signed-off-by: Xuesong Yang <[email protected]> Co-authored-by: Xuesong Yang <[email protected]>
That was unintentional. I would change it back to have the squeeze(1) in get_dist. Thanks for finding that. |
* add sleep Signed-off-by: Gerald Shen <[email protected]> * add sleep onto config instead Signed-off-by: Gerald Shen <[email protected]> * add comment Signed-off-by: Gerald Shen <[email protected]> --------- Signed-off-by: Gerald Shen <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
b5483a1
to
3206aeb
Compare
Gotcha, will open a new PR with this fix (and on top of |
What does this PR do ?
The TTS Aligner's
get_dist()
now has an extra dimension (from PR #6806); this PR fixes errors stemming from this in the Aligner notebook.@rlangman -- was the change from returning a (B, C, T)-dimensional tensor to a (B, 1, C, T)-dimensional one intentional? Do we want to keep that or change it back by adding a squeeze(1)?
Collection: TTS
PR Type: