Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add italian tokenization #7486

Merged
merged 11 commits into from
Sep 27, 2023
Merged

add italian tokenization #7486

merged 11 commits into from
Sep 27, 2023

Conversation

GiacomoLeoneMaria
Copy link
Contributor

What does this PR do ?

Add italian tokenization

@GiacomoLeoneMaria
add italian tokenization
5579499 
Signed-off-by: GiacomoLeoneMaria <[email protected]>
XuesongYang
XuesongYang reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@XuesongYang XuesongYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please also add some unit tests for italian tokenizer?

@XuesongYang XuesongYang merged commit 264cfe1 into NVIDIA:main Sep 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuesongYang XuesongYang XuesongYang approved these changes

@ekmb ekmb Awaiting requested review from ekmb

@redoctopus redoctopus Awaiting requested review from redoctopus

@rlangman rlangman Awaiting requested review from rlangman

Assignees
No one assigned
Labels
common TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GiacomoLeoneMaria @XuesongYang