Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old prompt table for storing cached ptunig representations #7295

Merged
merged 12 commits into from
Aug 25, 2023

Conversation

arendu
Copy link
Collaborator

@arendu arendu commented Aug 22, 2023

What does this PR do ?

caches ptuning representations in a simple embedding layer.

Collection: [NLP]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@arendu arendu requested a review from guyueh1 August 22, 2023 23:31
@github-actions github-actions bot added the NLP label Aug 22, 2023
self.clear_inference_table()
output_embeds = self.inner_forward()
else:
if not self.inference_table.is_inference_ready:
output_embeds = self.inner_forward()

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning

This assignment to 'output_embeds' is unnecessary as it is
redefined
before this value is used.
This assignment to 'output_embeds' is unnecessary as it is
redefined
before this value is used.
Copy link
Contributor

@guyueh1 guyueh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arendu arendu merged commit 455d2df into main Aug 25, 2023
15 checks passed
@arendu arendu deleted the adithyare/ptuning_table_update branch August 25, 2023 23:51
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
…IDIA#7295)

* remove old prompt table for storing cached ptunig representations

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* typo fix

Signed-off-by: arendu <[email protected]>

* update typo

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* wip

Signed-off-by: arendu <[email protected]>

* wip

Signed-off-by: arendu <[email protected]>

* using buffer to cache ptuning table

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: arendu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants