Adding server option to peft eval #7292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Mosallanezhad <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: David Mosallanezhad <[email protected]>
…davidm/peft_server_gpt
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from megatron.core import parallel_state | ||
|
|
||
| HAVE_MEGATRON_CORE = True | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
| from megatron.core import parallel_state | ||
|
|
||
| HAVE_MEGATRON_CORE = True | ||
| except: |
Check notice
Code scanning / CodeQL
Empty except Note
arendu
approved these changes
Aug 22, 2023
| @@ -179,6 +192,44 @@ def main(cfg) -> None: | |||
|
|
|||
| trainer.test(model) | |||
There was a problem hiding this comment.
can we skip traininer.test is cfg.server is used?
styagi130
pushed a commit
to styagi130/NeMo
that referenced
this pull request
Aug 23, 2023
* Adding server to peft eval Signed-off-by: David Mosallanezhad <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated trainer.test for server Signed-off-by: David Mosallanezhad <[email protected]> --------- Signed-off-by: David Mosallanezhad <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Siddharth Tyagi <[email protected]> Signed-off-by: Siddharth Tyagi <[email protected]>
dorotat-nv
pushed a commit
to dorotat-nv/NeMo
that referenced
this pull request
Aug 24, 2023
* Adding server to peft eval Signed-off-by: David Mosallanezhad <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated trainer.test for server Signed-off-by: David Mosallanezhad <[email protected]> --------- Signed-off-by: David Mosallanezhad <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: dorotat <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Adding server to peft eval Signed-off-by: David Mosallanezhad <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updated trainer.test for server Signed-off-by: David Mosallanezhad <[email protected]> --------- Signed-off-by: David Mosallanezhad <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adding server options to GPT PEFT eval
Collection: [Note which collection this PR will affect]
Changelog
Usage
python /data/NeMo/examples/nlp/language_modeling/tuning/megatron_gpt_peft_eval.py \ model.restore_from_path=/data/megatron_converted_2b_tp1_pp1.nemo \ model.peft.restore_from_path=/data/megatron_gpt_peft_tuning.nemo \ model.data.test_ds.file_names=['/models/dataset/squad/squad_subsamples_formatted_tn/100/1_squad_val.jsonl'] \ model.data.test_ds.global_batch_size=1 \ model.data.test_ds.micro_batch_size=1 \ model.data.test_ds.names=['squad'] \ model.data.test_ds.tokens_to_generate=30 \ server=True# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information