Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update numba support in docker #7271

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Update numba support in docker #7271

merged 1 commit into from
Aug 18, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Update Numba version in Docker

Collection: [ASR]

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@titu1994
Update numba support
bb330a0 
Signed-off-by: smajumdar <[email protected]>
@github-actions github-actions bot added the CI label Aug 18, 2023
aklife97
aklife97 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ericharper
ericharper approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit b479c90 into NVIDIA:main Aug 18, 2023
8 checks passed
@XuesongYang
Copy link
Collaborator

XuesongYang commented Aug 18, 2023 •
edited
Loading

@titu1994 @ericharper do we have to update this line in reinstall.sh, consistent with docker? https://github.com/NVIDIA/NeMo/blob/main/reinstall.sh#L23

styagi130 pushed a commit to styagi130/NeMo that referenced this pull request Aug 23, 2023
@titu1994 @siddhartht130
Update numba support (NVIDIA#7271)
026df29 
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Siddharth Tyagi <[email protected]>
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
@titu1994 @dorotat-nv
Update numba support (NVIDIA#7271)
038525b 
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: dorotat <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@titu1994
Update numba support (NVIDIA#7271)
161dfaa 
Signed-off-by: smajumdar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

@aklife97 aklife97 aklife97 approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@titu1994 @XuesongYang @ericharper @aklife97