Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Audio codec fixes #7266

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[TTS] Audio codec fixes #7266

merged 1 commit into from
Aug 18, 2023

Conversation

rlangman
Copy link
Collaborator

What does this PR do ?

A few minor fixes for the audio codec training recipe.

Most important, moving the zero_gradient() call back before the loss calculations. Having it after optim_disc.step() results in it saving discriminator gradients during the generator self.manual_backward(loss_gen_all) calculation which stops the discriminator from learning (adversarial and feature losses quickly become 0).

Collection: [TTS]

Changelog

  • Zero gradient before discriminator loss calculation
  • Change default mel loss scale from 1.0 to 5.0 as it significantly improves ViSQOL and makes training more consistent.
  • Fix name of validation time domain loss

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@rlangman rlangman requested a review from anteju August 18, 2023 14:35
@github-actions github-actions bot added the TTS label Aug 18, 2023
@anteju anteju merged commit 8454f57 into main Aug 18, 2023
15 checks passed
@anteju anteju deleted the encodec_fix branch August 18, 2023 16:53
styagi130 pushed a commit to styagi130/NeMo that referenced this pull request Aug 23, 2023
Signed-off-by: Ryan <[email protected]>
Signed-off-by: Siddharth Tyagi <[email protected]>
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants