Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASR] Fix GPU memory leak in transcribe_speech.py #7249

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

rlangman
Copy link
Collaborator

What does this PR do ?

Fix memory leak in utility used by transcribe_speech.py when transcribing partial audio segments, by moving logit tensor stored in results to CPU.

Collection: [ASR]

Changelog

  • Modify transcribe_partial_audio to move logits to CPU when when logprobs=False.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Copy link
Collaborator

@stevehuang52 stevehuang52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks~

@rlangman rlangman merged commit b7c8ef1 into main Aug 17, 2023
15 checks passed
@rlangman rlangman deleted the transcribe branch August 17, 2023 19:31
styagi130 pushed a commit to styagi130/NeMo that referenced this pull request Aug 23, 2023
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants