Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden transforms model parallel config + CI with Perceiver #7241

Merged
merged 23 commits into from
Aug 21, 2023
Merged

Hidden transforms model parallel config + CI with Perceiver #7241

merged 23 commits into from
Aug 21, 2023

Conversation

michalivne
Copy link
Collaborator

@michalivne michalivne commented Aug 15, 2023 •
edited
Loading

What does this PR do ?

This PR addresses:

  1. Compatibility with added ModelParallelConfig configuration.
  2. Adding to CI test for hidden transformations and Perceiver bottleneck models.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Aug 15, 2023
@github-actions github-actions bot added the CI label Aug 17, 2023
michalivne and others added 11 commits August 17, 2023 18:06
@michalivne
1. Removed debugging code.
533859b 
Signed-off-by: Micha Livne <[email protected]>
@michalivne
1. Fixed CI command argument (removed space).
61323ed 
Signed-off-by: Micha Livne <[email protected]>
@michalivne
Merge branch 'main' of github.com:NVIDIA/NeMo into hidden-transforms-CI
83e2b2d
@michalivne
1. Debugging. Signed-off-by: Micha Livne <[email protected]>
8ad2d27
@michalivne
1. Fixing CI command line.
2e2f0c9 
Signed-off-by: Micha Livne <[email protected]>
@michalivne
Merge branch 'main' of github.com:NVIDIA/NeMo into hidden-transforms-CI
844eb29
@michalivne
Merge branch 'main' into hidden-transforms-CI
32dcb1d
@michalivne
1. Fixed CI command.
4375f78 
Signed-off-by: Micha Livne <[email protected]>
@michalivne
Merge branch 'main' of github.com:NVIDIA/NeMo into hidden-transforms-CI
e20ca50
@michalivne
1. Debugging. Signed-off-by: Micha Livne <[email protected]>
89f2d33
@michalivne
1. Debugging. Signed-off-by: Micha Livne <[email protected]>
3acea30
ericharper
ericharper approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit c20a16e into NVIDIA:main Aug 21, 2023
11 checks passed
styagi130 pushed a commit to styagi130/NeMo that referenced this pull request Aug 23, 2023
@michalivne @siddhartht130
Hidden transforms model parallel config + CI with Perceiver (NVIDIA#7241
8f02a5f 
)

* 1. Fixed ModelParallelConfig compatibility.

Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Fixed Perceiver.

Signed-off-by: Micha Livne <[email protected]>

* 1. Added CI forhidden transformations (MIM) + Perceiver for Megatron.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Removed debugging code.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command argument (removed space).

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Fixing CI command line.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

---------

Signed-off-by: Micha Livne <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: Siddharth Tyagi <[email protected]>
styagi130 pushed a commit to styagi130/NeMo that referenced this pull request Aug 23, 2023
@michalivne @siddhartht130
Hidden transforms model parallel config + CI with Perceiver (NVIDIA#7241
2acb4ca 
)

* 1. Fixed ModelParallelConfig compatibility.

Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Fixed Perceiver.

Signed-off-by: Micha Livne <[email protected]>

* 1. Added CI forhidden transformations (MIM) + Perceiver for Megatron.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Removed debugging code.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command argument (removed space).

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Fixing CI command line.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

---------

Signed-off-by: Micha Livne <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: Siddharth Tyagi <[email protected]>

Signed-off-by: Siddharth Tyagi <[email protected]>
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
@michalivne @pre-commit-ci @dorotat-nv
Hidden transforms model parallel config + CI with Perceiver (NVIDIA#7241
f8d38cb 
)

* 1. Fixed ModelParallelConfig compatibility.

Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Fixed Perceiver.

Signed-off-by: Micha Livne <[email protected]>

* 1. Added CI forhidden transformations (MIM) + Perceiver for Megatron.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Removed debugging code.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command argument (removed space).

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Fixing CI command line.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

---------

Signed-off-by: Micha Livne <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: dorotat <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@michalivne @pre-commit-ci
Hidden transforms model parallel config + CI with Perceiver (NVIDIA#7241
aab3c4b 
)

* 1. Fixed ModelParallelConfig compatibility.

Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Fixed Perceiver.

Signed-off-by: Micha Livne <[email protected]>

* 1. Added CI forhidden transformations (MIM) + Perceiver for Megatron.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 1. Removed debugging code.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command argument (removed space).

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Fixing CI command line.

Signed-off-by: Micha Livne <[email protected]>

* 1. Fixed CI command.

Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

* 1. Debugging. Signed-off-by: Micha Livne <[email protected]>

---------

Signed-off-by: Micha Livne <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
CI NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michalivne @ericharper