Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add only trainable parameters to optimizer group in PEFT #7230

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Add only trainable parameters to optimizer group in PEFT #7230

merged 3 commits into from
Aug 17, 2023

Conversation

guyueh1
Copy link
Contributor

@guyueh1 guyueh1 commented Aug 14, 2023

  • Add only parameters with requires_grad=True to the optimizer group

What does this PR do ?

  • Add only the parameters with requires_grad=True to the optimizer group and skip frozen parameters. This change can reduce memory usage.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@guyueh1
Add only trainable parameters to optimizer group in PEFT
2ba5533 
* Add only parameters with requires_grad=True to the optimizer group

Signed-off-by: Guyue Huang <[email protected]>
@github-actions github-actions bot added the NLP label Aug 14, 2023
@arendu arendu self-requested a review August 16, 2023 17:24
arendu
arendu approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@arendu arendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arendu arendu merged commit ad2e3f3 into NVIDIA:main Aug 17, 2023
10 of 11 checks passed
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
@guyueh1 @dorotat-nv
Add only trainable parameters to optimizer group in PEFT (NVIDIA#7230)
77562e7 
* Add only parameters with requires_grad=True to the optimizer group

Signed-off-by: Guyue Huang <[email protected]>
Signed-off-by: dorotat <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@guyueh1
Add only trainable parameters to optimizer group in PEFT (NVIDIA#7230)
57dca67 
* Add only parameters with requires_grad=True to the optimizer group

Signed-off-by: Guyue Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendu arendu arendu approved these changes

Assignees
No one assigned
Labels
NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guyueh1 @arendu