Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attention mask inference #7213

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Fix attention mask inference #7213

merged 4 commits into from
Aug 14, 2023

Conversation

hsiehjackson
Copy link
Collaborator

What does this PR do ?

Fix inference.compute_attention_mask=True if not using FA

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Cheng-Ping Hsieh <[email protected]>
@github-actions github-actions bot added the NLP label Aug 11, 2023
ekmb
ekmb previously approved these changes Aug 11, 2023
@ekmb ekmb merged commit f4fd2f8 into main Aug 14, 2023
15 checks passed
@ekmb ekmb deleted the fix-infer-attention-mask branch August 14, 2023 18:28
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 14, 2023
* Fix attention mask inference

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Fix config

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

---------

Signed-off-by: Cheng-Ping Hsieh <[email protected]>
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
* Fix attention mask inference

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Fix config

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

---------

Signed-off-by: Cheng-Ping Hsieh <[email protected]>
Signed-off-by: dorotat <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Fix attention mask inference

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

* Fix config

Signed-off-by: Cheng-Ping Hsieh <[email protected]>

---------

Signed-off-by: Cheng-Ping Hsieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants