Fix consumed_samples which was off by one batch
#7212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odelalleau
force-pushed
the
od/consumed_samples
branch
from
f720447
to
0caab85
Compare
Signed-off-by: Olivier Delalleau <[email protected]>
odelalleau
force-pushed
the
od/consumed_samples
branch
from
0caab85
to
e6fda0f
Compare
|
NB: updated the commit with the "Signed-off" message in e6fda0f |
MaximumEntropy
approved these changes
Aug 13, 2023
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Olivier Delalleau <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]>
dorotat-nv
pushed a commit
to dorotat-nv/NeMo
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Olivier Delalleau <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Signed-off-by: dorotat <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
Signed-off-by: Olivier Delalleau <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
It fixes
consumed_samples, which was off by one batchCollection: nlp
Changelog
consumed_samples, which was off by one batchBefore your PR is "Ready for review"
Pre checks:
PR Type:
Additional Information
This could be an issue for instance when resuming an experiment and using the number of consumed samples to know where to start from (we would end up re-processing a batch that should have been skipped).