Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Discriminator update in AudioCodecModel #7209

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Aug 10, 2023

What does this PR do ?

This change removes random selection when deciding to update the discriminator in the AudioCodecModel.

Collection: TTS

Changelog

  • Instead of using a random number, update the discriminator disc_updates_per_period times for every disc_update_period batches
    • This fixes an issue when training with multiple GPUs
  • Added logging in audio_codec.py training script

Usage

N/A

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@anteju anteju requested a review from rlangman August 10, 2023 20:03
@github-actions github-actions bot added the TTS label Aug 10, 2023
@anteju anteju force-pushed the fix/audio-codec-distriminator-update branch from ee37d62 to c9766e0 Compare August 10, 2023 20:07
Copy link
Collaborator

@rlangman rlangman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anteju anteju merged commit ed4ce52 into NVIDIA:main Aug 10, 2023
11 checks passed
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 14, 2023
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants