Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

megatron gpt training fix #7199

Merged
merged 2 commits into from
Aug 10, 2023
Merged

megatron gpt training fix #7199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c8ef58
megatron gpt training fix when sequence parallel=True, transformer en…
Aug 9, 2023
b473a40
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nemo/collections/nlp/models/language_modeling/megatron_gpt_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,9 @@ def _append_sequence_parallel_module_grads(self, module, grads):
""" Helper method for allreduce_sequence_parallel_gradients"""

for param in module.parameters():
sequence_parallel_param = getattr(param, 'sequence_parallel', False)
sequence_parallel_param = getattr(param, 'sequence_parallel', False) or getattr(
param, 'sequence_parallel_enabled', False
)
# (@adithyare) adapter training now extends MegatronGPTModel
# so we have to add this check here to ensure we do not
# perform all_reduce when grad is None.
Expand Down
5 changes: 2 additions & 3 deletions nemo/collections/nlp/modules/common/megatron/fused_layer_norm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@


try:
from apex.normalization.fused_layer_norm import MixedFusedLayerNorm
from apex.transformer.layers.layer_norm import FastLayerNorm
from apex.transformer.layers.layer_norm import FastLayerNorm, MixedFusedLayerNorm

HAVE_APEX = True
except (ImportError, ModuleNotFoundError):
Expand Down Expand Up @@ -59,4 +58,4 @@ def get_layer_norm(hidden_size, eps=1e-5, persist_layer_norm=False, sequence_par
if persist_layer_norm:
return FastLayerNorm(hidden_size, eps, sequence_parallel_enabled=sequence_parallel)
else:
return MixedFusedLayerNorm(hidden_size, eps, sequence_parallel_enbaled=sequence_parallel)
return MixedFusedLayerNorm(hidden_size, eps, sequence_parallel_enabled=sequence_parallel)
Loading