Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TTS] Add license to ported EnCodec code #7197

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[TTS] Add license to ported EnCodec code #7197

merged 1 commit into from
Aug 10, 2023

Conversation

rlangman
Copy link
Collaborator

@rlangman rlangman commented Aug 9, 2023 •
edited
Loading

What does this PR do ?

Move code ported from EnCodec github into encodec_modules and add MIT Meta license to it.

https://github.com/facebookresearch/encodec/blob/main/LICENSE

Collection: [TTS]

Changelog

  • Copy/paste code from audio_codec_modules.py and vector_quantization.py into encodec_modules.py
  • Add MIT license

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@github-actions github-actions bot added the TTS label Aug 9, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 9, 2023
View reviewed changes
nemo/collections/tts/modules/encodec_modules.py

from typing import Iterable, Optional, Tuple

import torch

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note

Module 'torch' is imported with both 'import' and 'import from'.
@rlangman rlangman merged commit 9c818ed into main Aug 10, 2023
16 checks passed
@rlangman rlangman deleted the encodec_license branch August 10, 2023 22:38
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 14, 2023
@rlangman @guyueh1
[TTS] Add license to ported EnCodec code (NVIDIA#7197)
f0cdb8e 
Signed-off-by: Ryan <[email protected]>
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
@rlangman @dorotat-nv
[TTS] Add license to ported EnCodec code (NVIDIA#7197)
7dd1c23 
Signed-off-by: Ryan <[email protected]>
Signed-off-by: dorotat <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@rlangman
[TTS] Add license to ported EnCodec code (NVIDIA#7197)
3460323 
Signed-off-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anteju anteju anteju approved these changes

@XuesongYang XuesongYang Awaiting requested review from XuesongYang

@redoctopus redoctopus Awaiting requested review from redoctopus

@subhankar-ghosh subhankar-ghosh Awaiting requested review from subhankar-ghosh

Assignees
No one assigned
Labels
TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rlangman @anteju