Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Fix TTS recipes with PTL 2.0 #7188

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[TTS] Fix TTS recipes with PTL 2.0 #7188

merged 1 commit into from
Aug 9, 2023

Conversation

rlangman
Copy link
Collaborator

@rlangman rlangman commented Aug 8, 2023

What does this PR do ?

Update TTS configs so they run with PTL 2.0

Collection: [TTS]

Changelog

  • Replace ddp with ddp_find_unused_parameters_true for all vocoder recipes, otherwise it fails because there are unused parameters during the alternating generator and discriminator training steps.
  • Update training_epoch_end() for AudioCodec to be compatible with new PTL interface.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM

@rlangman rlangman merged commit ada4fe5 into main Aug 9, 2023
15 of 16 checks passed
@rlangman rlangman deleted the tts_ptl branch August 9, 2023 05:10
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants