Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pos id - hf update #7075

Merged
merged 3 commits into from
Jul 19, 2023
Merged

fix pos id - hf update #7075

merged 3 commits into from
Jul 19, 2023

Conversation

ekmb
Copy link
Collaborator

@ekmb ekmb commented Jul 19, 2023

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • [ X] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Evelina <[email protected]>
@github-actions github-actions bot added the NLP label Jul 19, 2023
titu1994
titu1994 previously approved these changes Jul 19, 2023
Signed-off-by: Evelina <[email protected]>
@titu1994 titu1994 merged commit c90625e into r1.20.0 Jul 19, 2023
13 checks passed
@titu1994 titu1994 deleted the pos_id_fix_r1.20.0 branch July 19, 2023 19:40
zhehuaichen pushed a commit to zhehuaichen/NeMo that referenced this pull request Oct 4, 2023
* fix pos id - hf update

Signed-off-by: Evelina <[email protected]>

* add missing import

Signed-off-by: Evelina <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Evelina <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zhehuaichen pushed a commit to zhehuaichen/NeMo that referenced this pull request Oct 4, 2023
* fix pos id - hf update

Signed-off-by: Evelina <[email protected]>

* add missing import

Signed-off-by: Evelina <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Evelina <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zhehuaichen pushed a commit to zhehuaichen/NeMo that referenced this pull request Oct 4, 2023
* fix pos id - hf update

Signed-off-by: Evelina <[email protected]>

* add missing import

Signed-off-by: Evelina <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Evelina <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
zhehuaichen pushed a commit to zhehuaichen/NeMo that referenced this pull request Oct 4, 2023
* fix pos id - hf update

Signed-off-by: Evelina <[email protected]>

* add missing import

Signed-off-by: Evelina <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Evelina <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: zhehuaichen <[email protected]>
zhehuaichen pushed a commit to zhehuaichen/NeMo that referenced this pull request Oct 4, 2023
* fix pos id - hf update

Signed-off-by: Evelina <[email protected]>

* add missing import

Signed-off-by: Evelina <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Evelina <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: zhehuaichen <[email protected]>
@ekmb ekmb mentioned this pull request Oct 26, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants