Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoPE length extrapolation with interpolation #7005
RoPE length extrapolation with interpolation #7005
Changes from 8 commits
b9287e3
0a4574b
6e79e92
363831e
95282d4
21739f0
9cf880a
f170ed2
5daffb7
9a6fab2
6d5f75e
f1d7cbe
61ac17f
bc6fe06
895d8bb
b60be05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these
modify config
,load_from_nemo
,load_from_checkpoint_dir
,validate_checkpoint_loading_args
functions are the same as in the SFT code. can we put them into an utility file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are almost the same not 100% identical. The issue is each one (SFT vs continued training) modifies some common attributes like
data
,optim
, but also a few different things.Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe not in this PR. we need to add seq_len_interpolation_factor for all the models that uses RoPe.