Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confidence ensembles RNNT logprobs selection logic for exclude_blank scenario #6937

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

KunalDhawan
Copy link
Collaborator

What does this PR do ?

  • Fixes the algorithm for filtering blank frames while building confidence ensembles
  • Adds checks for confidence value calculation to handle the edge case of all blank frames

Collection: [Note which collection this PR will affect]
ASR

Changelog

  • changes to get_filtered_logprobs() and compute_confidence() functions in nemo/collections/asr/models/confidence_ensembles.py

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

@KunalDhawan KunalDhawan requested a review from Kipok June 28, 2023 18:49
@github-actions github-actions bot added the ASR label Jun 28, 2023
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small issue to fix for consistency with rnnt logic.

By the way, were you able to figure out why rnnt probabilities are not correctly normalized?

nemo/collections/asr/models/confidence_ensemble.py Outdated Show resolved Hide resolved
@KunalDhawan KunalDhawan requested a review from Kipok June 28, 2023 21:20
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KunalDhawan KunalDhawan merged commit 47c9d74 into NVIDIA:main Jun 29, 2023
11 checks passed
@KunalDhawan KunalDhawan deleted the fix_confidence_ensembles branch June 29, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants