Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing save restore connector to eval scripts #6935

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Add missing save restore connector to eval scripts #6935

merged 3 commits into from
Jun 29, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Fix missing save restore connector to eval scripts to allow dynamically determining the values of model parallelism

Collection: [NLP]

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@github-actions github-actions bot added the NLP label Jun 28, 2023
ericharper
ericharper approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@titu1994 titu1994 merged commit 89225e4 into NVIDIA:main Jun 29, 2023
11 checks passed
@titu1994 titu1994 deleted the fix_eval branch June 29, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

Assignees
No one assigned
Labels
NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@titu1994 @ericharper