Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptuning oom fix #6916

Merged
merged 4 commits into from
Jun 27, 2023
Merged

ptuning oom fix #6916

merged 4 commits into from
Jun 27, 2023

Conversation

arendu
Copy link
Collaborator

@arendu arendu commented Jun 24, 2023

What does this PR do ?

The prompt learning dataset was not padding sequences to a multiple of 8 which forced a non-optimized version of softmax to be used resulting in more memory use and OOM errors. This PR pads to a multiple of 8 to reduce memory.

Collection: [NLP]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: arendu <[email protected]>
@github-actions github-actions bot added the NLP label Jun 24, 2023
@arendu arendu requested a review from aklife97 June 26, 2023 18:11
Signed-off-by: arendu <[email protected]>
aklife97
aklife97 previously approved these changes Jun 27, 2023
Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

just add comments for:

  1. why we're ceiliing
  2. this would not have any effect on seq parallel padding since TP sizes are powers of 2

Signed-off-by: arendu <[email protected]>
aklife97
aklife97 previously approved these changes Jun 27, 2023
@arendu arendu merged commit 7e3739b into main Jun 27, 2023
15 checks passed
@arendu arendu deleted the adithyare/ptuning_oom branch June 27, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants