Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for ONNX export of Megatron Models #6914

Merged
merged 9 commits into from
Jun 25, 2023

Conversation

asfiyab-nvidia
Copy link
Contributor

What does this PR do ?

Adds documentation for ONNX export of Megatron Models

@github-actions github-actions bot added the NLP label Jun 23, 2023
@ericharper ericharper requested a review from Davood-M June 23, 2023 17:40
@ericharper
Copy link
Collaborator

Could you add this to index.rst so it shows up in the navigation pane?

@asfiyab-nvidia
Copy link
Contributor Author

@ericharper would the docs/source/nlp/nemo_megatron be a better location for this file? I can then include it in the intro.rst under nemo_megatron

@ericharper
Copy link
Collaborator

I think it's better at a higher level

@ericharper
Copy link
Collaborator

I'm thinking below NeMo Megatron API:
image

@asfiyab-nvidia
Copy link
Contributor Author

Added the change. Is that what you had in mind?

@ericharper
Copy link
Collaborator

ericharper commented Jun 23, 2023

Added the change. Is that what you had in mind?

That is a good change.

But also link docs/source/nlp/megatron_onnx_export.rst to the table of contents: docs/source/index.rst

.. toctree::
   :maxdepth: 3
   :caption: Natural Language Processing
   :name: Natural Language Processing

   nlp/nemo_megatron/intro
   nlp/machine_translation/machine_translation
   nlp/text_normalization/intro
   nlp/api
   nlp/models

@asfiyab-nvidia
Copy link
Contributor Author

Ah I see, just included it in index.rst as well

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ericharper ericharper merged commit c4e677a into NVIDIA:main Jun 25, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants