Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rpe methods in bert-like models #6898

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

sararb
Copy link
Collaborator

@sararb sararb commented Jun 21, 2023

What does this PR do ?

Collection: [NLP]

Changelog

  • BERT:
    • nemo/collections/nlp/models/language_modeling/megatron_bert_model.py
    • nemo/collections/nlp/models/language_modeling/megatron/bert_model.py

Usage

model.position_embedding_type='' # Options ['learned_absolute', 'rope', 'alibi', 'xpos', 'sandwich', 'kerple']

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jun 21, 2023
@ekmb ekmb requested a review from michalivne June 21, 2023 22:21
@sararb sararb self-assigned this Jun 27, 2023
@sararb sararb merged commit 3b4f37a into NVIDIA:main Jun 28, 2023
11 checks passed
@sararb sararb deleted the bert-alibi branch June 28, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants