Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distopt API for coalesced NCCL calls #6886

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

timmoon10
Copy link
Collaborator

What does this PR do ?

The Pytorch API for coalescing NCCL calls has changed in 2.1.0 (see pytorch/pytorch#98793), which required some changes in the Apex wrapper functions (see NVIDIA/apex#1663).

Collection: NLP

Changelog

  • Use updated API for coalescing NCCL calls in distributed optimizer

Usage

Set the optimizer to distributed_fused_adam in the config file.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@timmoon10 timmoon10 added bug Something isn't working NLP labels Jun 19, 2023
@github-actions github-actions bot added CI core Changes to NeMo Core and removed NLP labels Jun 19, 2023
@timmoon10 timmoon10 marked this pull request as ready for review June 22, 2023 18:18
# container
RUN git clone https://github.com/NVIDIA/apex.git && \
cd apex && \
git checkout 57057e2fcf1c084c0fcc818f55c0ff6ea1b24ae2 && \
git checkout 8b7a1ff183741dd8f9b87e7bafd04cfde99cea28 && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commit needed with the dlfw 23.06 pytorch container?

@ericharper ericharper merged commit 0b6e4e6 into NVIDIA:main Jul 3, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants