Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final fix of notebook #6842

Merged
merged 1 commit into from
Jun 8, 2023
Merged

final fix of notebook #6842

merged 1 commit into from
Jun 8, 2023

Conversation

yidong72
Copy link
Collaborator

@yidong72 yidong72 commented Jun 8, 2023

use torchrun as verified by the QA

Signed-off-by: Yi Dong <[email protected]>
@github-actions github-actions bot added the NLP label Jun 8, 2023
@yidong72 yidong72 requested a review from ericharper June 8, 2023 23:01
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 4239b80 into r1.19.0 Jun 8, 2023
8 of 10 checks passed
@ericharper ericharper deleted the fix_notebook2 branch June 8, 2023 23:05
github-actions bot pushed a commit that referenced this pull request Jun 8, 2023
Signed-off-by: Yi Dong <[email protected]>
XuesongYang pushed a commit that referenced this pull request Jun 13, 2023
Signed-off-by: Yi Dong <[email protected]>
Co-authored-by: Yi Dong <[email protected]>
ericharper pushed a commit that referenced this pull request Jun 29, 2023
Signed-off-by: Yi Dong <[email protected]>
ericharper added a commit that referenced this pull request Jun 29, 2023
* Cut branch r1.19.0

Signed-off-by: smajumdar <[email protected]>

* Tutorial fixes (#6717)

Signed-off-by: smajumdar <[email protected]>

* fix notebook error (#6840)

Signed-off-by: Yi Dong <[email protected]>

* fix (#6842)

Signed-off-by: Yi Dong <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

* update package info

Signed-off-by: ericharper <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Yi Dong <[email protected]>
Signed-off-by: ericharper <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Yi Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants