Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ub communicator initialization to validation step #6807

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add ub communicator initialization to validation step #6807

merged 1 commit into from
Jun 5, 2023

Conversation

erhoo82
Copy link
Collaborator

@erhoo82 erhoo82 commented Jun 3, 2023

What does this PR do ?

Fix TP-comm overlap with userbuffer, where validation step precedes a training step.

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jun 3, 2023
aklife97
aklife97 approved these changes Jun 3, 2023
View reviewed changes
Copy link
Collaborator

@aklife97 aklife97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ericharper
ericharper approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 0e0253e into r1.19.0 Jun 5, 2023
9 checks passed
@ericharper ericharper deleted the slym/r1.19.0_cleanup branch June 5, 2023 15:36
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
@erhoo82 @web-flow
Add ub communicator initialization to validation step (#6807)
16ff138
ericharper added a commit that referenced this pull request Jun 29, 2023
@github-actions @erhoo82 @ericharper
Add ub communicator initialization to validation step (#6814)
7e6e04a 
* Add ub communicator initialization to validation step (#6807)

* fix code qol

Signed-off-by: ericharper <[email protected]>

---------

Signed-off-by: ericharper <[email protected]>
Co-authored-by: Sangkug Lym <[email protected]>
Co-authored-by: ericharper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericharper ericharper ericharper approved these changes

@aklife97 aklife97 aklife97 approved these changes

Assignees
No one assigned
Labels
NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erhoo82 @ericharper @aklife97