Add trainer.validate example for GPT #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
titu1994
previously approved these changes
Jun 2, 2023
| trainer=trainer, | ||
| override_config_path=pretrained_cfg, | ||
| save_restore_connector=save_restore_connector, | ||
| map_location=f'cuda:{trainer.local_rank}', # map_location is needed for converted models |
There was a problem hiding this comment.
I don't use this usually, is it needed ?
There was a problem hiding this comment.
only for converted checkpoints
There was a problem hiding this comment.
Right I do inference with converted checkpoint and had no issues. Oh well if it doesn't hurt then it's ok
There was a problem hiding this comment.
I'll test this again to see if we do need it
There was a problem hiding this comment.
lets merge this in for current release and we can remove the map location if we don't need it later - doesn't hurt keeping it there for now
Signed-off-by: ericharper <[email protected]>
|
Does this script allow you to make the GPTModel score a dataset supplied via args? That would be very useful. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
* add trainer.validate example Signed-off-by: ericharper <[email protected]> * clean up white space Signed-off-by: ericharper <[email protected]> * add mbs and gbs to the config Signed-off-by: ericharper <[email protected]> --------- Signed-off-by: ericharper <[email protected]>
ericharper
added a commit
that referenced
this pull request
Jun 18, 2023
* add trainer.validate example * clean up white space * add mbs and gbs to the config --------- Signed-off-by: ericharper <[email protected]> Co-authored-by: Eric Harper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enables an example of calling trainer.validate with GPT.
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information