Fix adapter tutorial r1.19.0 #6776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuesongYang
reviewed
May 31, 2023
| out = self.gst_module(reference_spec, reference_spec_lens) | ||
| embs = out if embs is None else embs + out | ||
| else: | ||
| logging.warning("You may add `gst_module` in speaker_encoder to use reference_audio.") |
There was a problem hiding this comment.
Why do we relax the logging level to warning from errors? I was wondering if we should raise errors when the behavior is not expected.
There was a problem hiding this comment.
We previously raise error when the model has gst_module and users don't provide reference_spec.
However, there is a scenario we pre-compute the speaker embeddings of gst_module, so the model still has gst_module but we don't provide reference_spec anymore.
There was a problem hiding this comment.
Thanks. it is fine for me. @rlangman @redoctopus any thoughts?
There was a problem hiding this comment.
Fine with me, though could you add a sentence in the warning telling users what it does by default instead?
hsiehjackson
force-pushed
the
fix_adapter_tutorial_r1.19.0
branch
2 times, most recently
from
85d4230
to
d56ee88
Compare
XuesongYang
approved these changes
Jun 1, 2023
hsiehjackson
force-pushed
the
fix_adapter_tutorial_r1.19.0
branch
from
d56ee88
to
b2db88c
Compare
Signed-off-by: hsiehjackson <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson
force-pushed
the
fix_adapter_tutorial_r1.19.0
branch
from
b2db88c
to
350ef59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix adapter tutorial to compatible with latest pre-traiend FastPitch checkpoint
Collection: [TTS]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information