Bug fix to reset sequence parallelism #6756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markel Sanz Ausin <[email protected]>
Signed-off-by: Markel Sanz Ausin <[email protected]>
ericharper
reviewed
May 30, 2023
| @@ -1186,5 +1186,6 @@ def _restore_sequence_parallelism_args(self): | |||
| self.cfg.sequence_parallel = self.last_sequence_parallel | |||
|
|
|||
| # Restore model parameters. | |||
| for module in self.get_gpt_module_list(): | |||
| module.language_model.encoder.sequence_parallel = self.last_sequence_parallel | |||
| for module in self.model.modules(): | |||
There was a problem hiding this comment.
I think this needs to be a double loop:
for module in self.get_gpt_module_list():
for mod in module.modules():
if hasattr(mod, "sequence_parallel"):
...There was a problem hiding this comment.
Fixed. Please double check @ericharper
Signed-off-by: Markel Sanz Ausin <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 31, 2023
* Bug fix to reset sequence parallelism Signed-off-by: Markel Sanz Ausin <[email protected]> * Update seq par reset/restore Signed-off-by: Markel Sanz Ausin <[email protected]> * Add nested loop Signed-off-by: Markel Sanz Ausin <[email protected]> --------- Signed-off-by: Markel Sanz Ausin <[email protected]>
markelsanz14
added a commit
that referenced
this pull request
May 31, 2023
* Bug fix to reset sequence parallelism * Update seq par reset/restore * Add nested loop --------- Signed-off-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* Bug fix to reset sequence parallelism * Update seq par reset/restore * Add nested loop --------- Signed-off-by: Markel Sanz Ausin <[email protected]> Co-authored-by: Markel Sanz Ausin <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
yaoyu-33
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Bug fix to reset sequence parallelism Signed-off-by: Markel Sanz Ausin <[email protected]> * Update seq par reset/restore Signed-off-by: Markel Sanz Ausin <[email protected]> * Add nested loop Signed-off-by: Markel Sanz Ausin <[email protected]> --------- Signed-off-by: Markel Sanz Ausin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes sequence parallelism reset function to set the value to False instead of None.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information