Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharded manifests docs #6751

Merged
merged 1 commit into from
May 29, 2023
Merged

sharded manifests docs #6751

merged 1 commit into from
May 29, 2023

Conversation

bmwshop
Copy link
Collaborator

@bmwshop bmwshop commented May 29, 2023

What does this PR do ?

Adds documentation on the use of sharded manifests

Collection: ASR

Changelog

  • docs/source/asr/datasets.rst changed to add the docs

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • [ X] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Dima Rekesh <[email protected]>
@github-actions github-actions bot added the ASR label May 29, 2023
@bmwshop bmwshop requested a review from titu1994 May 29, 2023 16:13
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit c1abc04 into main May 29, 2023
9 of 12 checks passed
@titu1994 titu1994 deleted the shman_docs branch May 29, 2023 17:10
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Dima Rekesh <[email protected]>
Co-authored-by: Dima Rekesh <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants