Fix checkpointed forward and add test for full activation checkpointing #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhinav Khattar <[email protected]>
Signed-off-by: Abhinav Khattar <[email protected]>
Signed-off-by: Abhinav Khattar <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 31, 2023
…ng (#6744) * fix checkpointed forward and add test for full activation checkpointing Signed-off-by: Abhinav Khattar <[email protected]> * add method Signed-off-by: Abhinav Khattar <[email protected]> * add method Signed-off-by: Abhinav Khattar <[email protected]> --------- Signed-off-by: Abhinav Khattar <[email protected]>
aklife97
added a commit
that referenced
this pull request
May 31, 2023
…ng (#6744) (#6771) * fix checkpointed forward and add test for full activation checkpointing * add method * add method --------- Signed-off-by: Abhinav Khattar <[email protected]> Co-authored-by: Abhinav Khattar <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
…ng (NVIDIA#6744) (NVIDIA#6771) * fix checkpointed forward and add test for full activation checkpointing * add method * add method --------- Signed-off-by: Abhinav Khattar <[email protected]> Co-authored-by: Abhinav Khattar <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
yaoyu-33
pushed a commit
that referenced
this pull request
Oct 16, 2023
…ng (#6744) * fix checkpointed forward and add test for full activation checkpointing Signed-off-by: Abhinav Khattar <[email protected]> * add method Signed-off-by: Abhinav Khattar <[email protected]> * add method Signed-off-by: Abhinav Khattar <[email protected]> --------- Signed-off-by: Abhinav Khattar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes checkpointed forward and changes GPT TP test to use activation recomputation for 1 layer instead of SAR
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information