Fix TTS adapter tutorial #6741
Merged
Fix TTS adapter tutorial #6741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hsiehjackson <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: hsiehjackson <[email protected]>
hsiehjackson
force-pushed
the
fix_adapter_tutorial
branch
from
ecd4060
to
282f28b
Compare
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "wave_model = WaveformFeaturizer(sample_rate=sample_rate)" |
There was a problem hiding this comment.
why was this removed? This object is needed for converting wav -> features
There was a problem hiding this comment.
We don't need to use reference_spec during inference, so we don't need to get the audio features. The only thing we need is the model and text.
hsiehjackson
added a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* Fix adapter tutorial Signed-off-by: hsiehjackson <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix typos Signed-off-by: hsiehjackson <[email protected]> --------- Signed-off-by: hsiehjackson <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix adapter tutorial to compatible with latest pre-traiend FastPitch checkpoint
Collection: [TTS]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information