Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] fix inconsistent type hints for IpaG2p #6733

Merged
merged 1 commit into from
May 26, 2023
Merged

[TTS] fix inconsistent type hints for IpaG2p #6733

merged 1 commit into from
May 26, 2023

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented May 25, 2023

What does this PR do ?

The type hint was mismatched with https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/tts/g2p/models/i18n_ipa.py#L159.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@XuesongYang XuesongYang merged commit 84577c9 into main May 26, 2023
11 checks passed
@XuesongYang XuesongYang deleted the fix-types branch May 26, 2023 00:34
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants