Fix fastpitch test nightly #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hsiehjackson <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
for more information, see https://pre-commit.ci
hsiehjackson
force-pushed
the
fix-fastpitch-test
branch
from
6809c70
to
87f9982
Compare
rlangman
previously approved these changes
May 25, 2023
Comment on lines
+46
to
+51
| speaker_id = None | ||
| reference_spec = None | ||
| reference_spec_lens = None | ||
|
|
||
| if hasattr(model.fastpitch, 'speaker_emb'): | ||
| speaker_id = 0 |
There was a problem hiding this comment.
Nitpick: could create a helper function to handle the branching logic easier, like:
def _get_inputs(model):
if hasattr(model.fastpitch, 'speaker_emb'):
return 0, None, None
if not hasattr(model.fastpitch, 'speaker_encoder'):
None, None, None
...
There was a problem hiding this comment.
agreed. but it seems this add-ons are only applied to fastpitch models, not all. It looks good to just keep as-is.
XuesongYang
previously approved these changes
May 26, 2023
Comment on lines
+46
to
+51
| speaker_id = None | ||
| reference_spec = None | ||
| reference_spec_lens = None | ||
|
|
||
| if hasattr(model.fastpitch, 'speaker_emb'): | ||
| speaker_id = 0 |
There was a problem hiding this comment.
agreed. but it seems this add-ons are only applied to fastpitch models, not all. It looks good to just keep as-is.
|
could you please also file the same PR to r1.19.0 branch? |
Signed-off-by: hsiehjackson <[email protected]>
XuesongYang
approved these changes
May 26, 2023
hsiehjackson
added a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* fix test fastpitch nightly Signed-off-by: hsiehjackson <[email protected]> * Reformat Signed-off-by: hsiehjackson <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix if elif condition Signed-off-by: hsiehjackson <[email protected]> --------- Signed-off-by: hsiehjackson <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix multi-speaker FastPitch test nightly
Collection: [TTS]
Changelog
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information