Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Filter out silent audio files during preprocessing #6716

Merged
merged 1 commit into from
May 24, 2023

Conversation

rlangman
Copy link
Collaborator

What does this PR do ?

First version of preprocessing ignored audio files where start/end of speech could not be detected. During testing I find that all such examples are silent audio files with no speech. And that most public datasets have several such files. This updates the script to remove such files from the final training manifest.

Collection: [TTS]

Changelog

  • Update preprocessing script to remove silent/empty audio files from final training manifest.
  • Add overwrite_audio so that is script fails partway, you can resume where you left off instead of having to reprocess the entire dataset.
  • Fix parsing of overwrite arguments, as trying to parse them as a bool results in True regardless of what value you provide in the CLI.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes

@rlangman rlangman merged commit 372f519 into main May 24, 2023
9 checks passed
@rlangman rlangman deleted the tts_preprocess branch May 24, 2023 19:54
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants