check for first or last stage #6708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ericharper <[email protected]>
yidong72
reviewed
May 23, 2023
| compute_prob_response['offsets'] = offsets | ||
| return compute_prob_response | ||
| if ( | ||
| not parallel_state.model_parallel_is_initialized() |
There was a problem hiding this comment.
why we need this condition not parallel_state.model_parallel_is_initialized()?
if the model_parallel is not initialized, it will throw an exception at the very beginning right?
There was a problem hiding this comment.
I was just trying to make it robust. This method will only be called after parallel_state is initialized?
There was a problem hiding this comment.
this parallel_state.model_parallel_is_initialized() method will always be true after parallel init.
def model_parallel_is_initialized():
"""Check if model and data parallel groups are initialized."""
if _TENSOR_MODEL_PARALLEL_GROUP is None or \
_PIPELINE_MODEL_PARALLEL_GROUP is None or \
_DATA_PARALLEL_GROUP is None:
return False
return TrueThere was a problem hiding this comment.
I mean will this method ever be used without model parallel init?
There was a problem hiding this comment.
no. it is only used with model parallel.
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
yidong72
approved these changes
May 24, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 26, 2023
* check for first or last stage Signed-off-by: ericharper <[email protected]> * remove redundant check Signed-off-by: ericharper <[email protected]> * fix typo Signed-off-by: ericharper <[email protected]> * add map_location Signed-off-by: ericharper <[email protected]> --------- Signed-off-by: ericharper <[email protected]>
ericharper
added a commit
that referenced
this pull request
May 27, 2023
* check for first or last stage * remove redundant check * fix typo * add map_location --------- Signed-off-by: ericharper <[email protected]> Co-authored-by: Eric Harper <[email protected]>
hsiehjackson
pushed a commit
to hsiehjackson/NeMo
that referenced
this pull request
Jun 2, 2023
* check for first or last stage * remove redundant check * fix typo * add map_location --------- Signed-off-by: ericharper <[email protected]> Co-authored-by: Eric Harper <[email protected]> Signed-off-by: hsiehjackson <[email protected]>
yaoyu-33
pushed a commit
that referenced
this pull request
Oct 16, 2023
* check for first or last stage Signed-off-by: ericharper <[email protected]> * remove redundant check Signed-off-by: ericharper <[email protected]> * fix typo Signed-off-by: ericharper <[email protected]> * add map_location Signed-off-by: ericharper <[email protected]> --------- Signed-off-by: ericharper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix bug when
inference.compute_logprob=True. Only first and last pipeline stages have a response.Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information