Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

karpnv/issues6690 #6705

Merged
merged 5 commits into from
May 23, 2023
Merged

karpnv/issues6690 #6705

merged 5 commits into from
May 23, 2023

Conversation

karpnv
Copy link
Collaborator

@karpnv karpnv commented May 23, 2023

What does this PR do ?

install ctc_decoders inside venv

Collection: ASR

Changelog

  • Fix install_beamsearch_decoders.sh to work outside container

Usage

  • Install NeMo ctc-decoders locally inside Conda venv
# make NeMo venv
conda create --name nemo python==3.8.10
conda activate nemo

# install NeMo
sudo apt-get update && apt-get install -y libsndfile1 ffmpeg
git clone https://github.com/NVIDIA/NeMo
cd NeMo
./reinstall.sh

# install ctc-decoders
./scripts/asr_language_modeling/ngram_lm/install_beamsearch_decoders.sh $(pwd)

PR Type:

  • [ X] Bugfix

Who can review?

@titu1994

Additional Information

@karpnv karpnv requested review from VahidooX and titu1994 May 23, 2023 16:53
titu1994
titu1994 approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@titu1994 titu1994 merged commit 2ea9b18 into main May 23, 2023
10 of 11 checks passed
@titu1994 titu1994 deleted the karpnv/issues6690 branch May 23, 2023 18:02
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
@karpnv @pre-commit-ci @hsiehjackson
karpnv/issues6690 (NVIDIA#6705)
b70dbf7 
* add sudo

Signed-off-by: Nikolay Karpov <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* RUN

Signed-off-by: Nikolay Karpov <[email protected]>

---------

Signed-off-by: Nikolay Karpov <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

@VahidooX VahidooX Awaiting requested review from VahidooX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karpnv @titu1994